looks to me, the phandles should be outside root node.

I tried that and it didnt work

you get the same error message?

-- Found BOARD.dts: /home/zacck/zephyrproject/zephyr/boards/st/stm32f4_disco/stm32f4_disco.dts
-- Found devicetree overlay: /home/zacck/zephyrproject/zephyr/samples/basic/blinky_pwm/boards/stm32f4_disco.overlay
devicetree error: 'pinmux' is marked as required in 'properties:' in /home/zacck/zephyrproject/zephyr/dts/bindings/pinctrl/st,stm32-pinctrl.yaml, but does not appear in 
CMake Error at /home/zacck/zephyrproject/zephyr/cmake/modules/dts.cmake:303 (execute_process):
  execute_process failed command indexes:

    1: "Child return code: 1"

Call Stack (most recent call first):
  /home/zacck/zephyrproject/zephyr/cmake/modules/zephyr_default.cmake:133 (include)
  /home/zacck/zephyrproject/zephyr/share/zephyr-package/cmake/ZephyrConfig.cmake:66 (include)
  /home/zacck/zephyrproject/zephyr/

I got past that by setting up the aliases unless there is a part of the error I am missing.

can you remove `group1` and have the properties directly under the `pwn_d12_default` node

I can go back to this

ok here look this builds

/ {
  aliases {
        pwm-led0 = &green_pwm_led;
  };
};


  &pwm4 {
    status = "okay";
  };

this is all I needed in the overlay

/ {
    aliases {
        pwm-led0 = &green_pwm_led;
    };
};



&pwmleds {
    status = "okay";
};

&pwm4 {
    status = "okay";
};

I think the pwmleds are not enabled by default

i think it’s all just different naming conventions

My issue now is prescalers and clocks via device tree, wish me luck

should’nt the pwm driver handle those?

Because first of all, I know the clock is preset for me but I can’t find a peek api to tell me and I’m too lazy to go look at registers right now